ECOM-27390 add withdrawalRequested to FetchedOrder#559
Merged
Conversation
n-viktorovich
force-pushed
the
ECOM-27390
branch
from
f30bbf4 to
ba3827b
Compare
n-viktorovich
force-pushed
the
ECOM-27390
branch
from
d82a51b to
e56c3a1
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new withdrawal indicator field to the FetchedOrder result DTO and updates the test rule suites to account for the new property metadata (nullable + non-updatable). Also adjusts a cart calculation test expectation for handlingFee.
Changes:
- Add
withdrawalRequestednullable Boolean field toFetchedOrder. - Update nullable/non-updatable property rule lists to include the new field.
- Update
CartsTestto asserthandlingFeeis0.0(and remove unusedassertNullimport).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/com/ecwid/apiclient/v3/dto/order/result/FetchedOrder.kt | Adds the new withdrawalRequested field to the fetched order DTO. |
| src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/FetchedOrderRules.kt | Allows the new field to be nullable in nullable-property rule tests. |
| src/test/kotlin/com/ecwid/apiclient/v3/rule/NonUpdatablePropertyRules.kt | Marks the new field as read-only in non-updatable rule tests. |
| src/test/kotlin/com/ecwid/apiclient/v3/entity/CartsTest.kt | Updates expected handling fee value in calculated order item assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
n-viktorovich
changed the title
mamirovlspeed
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.